Sign in Register
Go to solution
Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Calle Bjernekull 28 posts 103 karma points
    Nov 15, 2016 @ 14:46
    Calle Bjernekull
    0

    HTML Size

    Issues and suggestions
    Umbraco 7

    Hi, I have a question regarding how you calculate the size of html-document. You are calculating the size in AnalyzeService.AnalyzeWebPage() by the method:

    Encoding.ASCII.GetByteCount(htmlString);

    This seems to be correct. But you are also doing another calculation in HtmlSizeAnalyzer.Analyse(), whare you are using 

    Encoding.Unicode.GetByteCount(document.InnerHtml);

    This will calculate the size to about twice as large as it is, which gives me warnings in the tool.

    I might be wrong here, but shouldn't these two methods calculate the size with ASCII-encoding?

    When testing my pages in external tools, I don't get these warnings. But I get them when analysing with Rank One

    Copy Link
  • Mark Wemekamp 73 posts 385 karma points
    Nov 17, 2016 @ 20:13
    Mark Wemekamp
    1

    Hi Calle,

    Thanks for reporting this

    It should definitely be the ascii bytecount, going to fix this as soon as possible.

    I'll keep you posted

    Copy Link
  • Mark Wemekamp 73 posts 385 karma points
    Nov 18, 2016 @ 19:37
    Mark Wemekamp
    100

    This should be fixed now in v0.3.5

    Copy Link
  • Calle Bjernekull 28 posts 103 karma points
    Dec 13, 2016 @ 13:25
    Calle Bjernekull
    0

    Sorry for late reply, this works much bettrer now. Thank you! Have two other suggestions, but I'll post them as separate threads

    Copy Link
Please Sign in or register to post replies

Write your reply to:

Draft