Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • David Peck 687 posts 1863 karma points c-trib
    Mar 13, 2021 @ 14:55
    David Peck
    0

    UmbracoProductAdapter.GetProductSnapshot(,,) not virtual

    I've been overriding UmbracoProductAdapter.GetProductSnapshot(string productReference, string languageIsoCode). With the introduction of GetProductSnapshot(string productReference, string productVariantReference, string languageIsoCode) I wanted to override that as well but it isn't virtual.

    My workaround is to wrap UmbracoProductAdapter, but I thought I'd log this issue (assuming you want this isn't intentional).

  • Matt Brailsford 4124 posts 22215 karma points MVP 9x c-trib
    Mar 13, 2021 @ 17:14
    Matt Brailsford
    100

    Good spot!

    Would you mind raising it on the issue tracker though as that is where we track issues https://github.com/vendrhub/vendr/issues, the forums are more for discussions / how can I do X, Y and Z?

    👍

  • David Peck 687 posts 1863 karma points c-trib
    Mar 15, 2021 @ 11:59
    David Peck
    0

    It's not a difficult distinction, but I seem to struggle with it

Please Sign in or register to post replies

Write your reply to:

Draft