Thanks for this great package, it solves my site translation needs perfectly.
Recently I upgraded Umbraco to 7.3.2 and then needed to change how the languages are displayed in Polyglot. I downloaded the code, changed the LanguageSelector.ascx.cs and re-compiled.
All went well but I get two warnings:
UmbracoDatabase.UmbracoDatabase(string)' is obsolete: 'Use the other constructor specifying an ILogger instead' Dimi.Polyglot\DAL\UmbracoDatabase.cs Line 7
Language' is obsolete: 'Use the LocalizationService instead' Languages.cs Line 87
Do you have any plans to update Polyglot to fix these?
You're welcome! Many thanks for the nice feedback and for letting me know about the warnings! I haven't compiled the package for a long time so I had no idea. I will correct these issues and let you know. It should take a couple of days before the next release.
Sorry for the delay. I have tried updating the package for the latest Umbraco version as discussed. However, because the new methods do not exist in the older Umbraco dlls, I would need to split the releases and maintain an extra release, so I will not be doing that for now. I will reintroduce the changes if the old methods get removed at some point. Nevertheless, in case you would like to try out or use the source code, here is the relevant commit:
Update for 7.3.x?
Hi Dmitri,
Thanks for this great package, it solves my site translation needs perfectly.
Recently I upgraded Umbraco to 7.3.2 and then needed to change how the languages are displayed in Polyglot. I downloaded the code, changed the LanguageSelector.ascx.cs and re-compiled.
All went well but I get two warnings:
Do you have any plans to update Polyglot to fix these?
Thanks & Regards
Ver
Hi Veronica,
You're welcome! Many thanks for the nice feedback and for letting me know about the warnings! I haven't compiled the package for a long time so I had no idea. I will correct these issues and let you know. It should take a couple of days before the next release.
Kind regards,
Dimitri
Hi Veronica,
Sorry for the delay. I have tried updating the package for the latest Umbraco version as discussed. However, because the new methods do not exist in the older Umbraco dlls, I would need to split the releases and maintain an extra release, so I will not be doing that for now. I will reintroduce the changes if the old methods get removed at some point. Nevertheless, in case you would like to try out or use the source code, here is the relevant commit:
https://github.com/dimitrikourk/Polyglot/tree/1078fedd2f68260b033c3736bd8b3c6275723389
Best regards,
Dimitri
Hi Dimitri,
Thanks for looking into this and the code. I can understand not wanting or not having the time to support multiple versions of the package.
Regards
Ver
is working on a reply...