Hi Harm,

Sounds like a good way of doing it but you can probably improve the code. Do you mind sharing the snippet?

Thanks for the comment Tim, here's the code for the confirmation control.

Like i said, i've just started developing in .Net so there's probably a lot that can be improved but the important thing is that it's way to slow.

namespace ConfirmControl
{
    public partial class ConfirmControl : System.Web.UI.UserControl
    {
        public string bevestigdMsg { get; set; }        
        public string alBevestigdMsg { get; set; }
        public string ongeldigMsg { get; set; }

        protected void Page_Load(object sender, EventArgs e)
        {
            String qsRecord = Request.QueryString["rid"];
            String qsSecret = Request.QueryString["cid"];
            Int16 emailCount = 0;

            if (IsGUID(qsRecord) && !String.IsNullOrEmpty(qsSecret) && !String.IsNullOrEmpty(qsRecord))
            {
                Umbraco.Forms.Data.Storage.RecordStorage storage = new Umbraco.Forms.Data.Storage.RecordStorage();
                Umbraco.Forms.Core.Record record = storage.GetRecord(new Guid(qsRecord));

                if (storage.GetAllRecords(record.Form).Count > 0)
                {
                    IEnumerable rList = storage.GetAllRecords(record.Form);
                    foreach (Record rec in rList)
                    {
                        if (rec.State.ToString() == "Approved" && String.Equals(rec.GetRecordField("Emailadres:").Values[0].ToString(), record.GetRecordField("Emailadres:").Values[0].ToString(), StringComparison.CurrentCultureIgnoreCase))
                            emailCount += 1;
                    }
                }

                RecordService rs = new RecordService(record);

                String strSecret = FormsAuthentication.HashPasswordForStoringInConfigFile(topsecretproperty, System.Web.Configuration.FormsAuthPasswordFormat.MD5.ToString());
                Boolean checkSecret = String.Equals(qsSecret, strSecret, StringComparison.CurrentCultureIgnoreCase);

                if (checkSecret)
                {
                    if (emailCount == 0)
                    {
                        MsgLabel.Text = bevestigdMsg;
                        rs.Approve();
                    }
                    else
                        MsgLabel.Text = alBevestigdMsg;
                }
                else
                    MsgLabel.Text = ongeldigMsg;

                rs.Dispose();
            }
            else
                MsgLabel.Text = ongeldigMsg;
        }

        public static bool IsGUID(string expression)
        {
            if (expression != null)
            {
                Regex guidRegEx = new Regex(@"^(\{{0,1}([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}\}{0,1})$");

                return guidRegEx.IsMatch(expression);
            }
            return false;
        }
    }
}

Narrowed down to this code it's still way too slow:

Umbraco.Forms.Data.Storage.RecordStorage storage = new Umbraco.Forms.Data.Storage.RecordStorage();
List<Umbraco.Forms.Core.Record> recordList = storage.GetAllRecords(new Guid("[formguid]"));

foreach (Record rec in recordList)
{
    if (rec.State.ToString() == "Approved")
        doStuff(rec.GetRecordField("Emailadres:").ValuesAsString());
}

Sorry to bump this but i am still looking for a way to loop and check a couple thousand contour records the right way.
Is GetAllRecords the right method for this? I can't specify a pageId because voting takes place on different pages.

Any tips are much appreciated.

Hi There,

I know this is a couple of years after the party, but did you ever find a quicker way of looping through the records?

I'm finding myself in need of looping through 50k+ records. I'm only needing to do it once every now and then as I'm using Lucene to index the results for lightning fast searching, but to rebuild the index is stupidly slow.. It's hammerring SQL..

Mark

is working on a reply...