I can tell you when i'm doing something like this i'm getting my page Id

@{
var myLink = "#";
    if(Boxes.HasValue("internalLink"))
    {
    myLink = Boxes.internalLink;
    }
    <a href="#">@myLink</a>
} 

Hi Mads,

Try to put .Url on @myLink, and see if you get the link instead of the ID for the page.

@{
var myLink ="#";
    if(Boxes.HasValue("internalLink"))
    {
    myLink =Boxes.internalLink;
    }
    <a href="#">@myLink.Url</a>
}

I hope this helps you.

/Dennis

Hey Dennis 
I've already been there :D

It just gives me an error :(

Error loading MacroEngine script (file: FrontpageFokusBoxs.cshtml) 

Does anyone have another suggestion? 

Hi Mads

First question, is this a Partial View Macro or are using using legacy Razor Macro? Next question, are you using MVC templates or WebForms?

Jeavon

Given you a using Umbraco v7, you should be using MVC templates or Partial View Macros with WebForms templates, therefore something Ike this:

@{ var myLink ="#";
     if(CurrentPage.HasValue("internalLink"))
     {
    myLink = Umbraco.Content(CurrentPage.internalLink).Url;
    }
    <a href="@myLink">mylink</a> }

Hi Jeavon Yes, i'm running full MVC. I'll try your suggestion :D

Right now i'm using Razor Macros on my views/mastertemplates?

Should I use Partial views Instead of Macros? and what is the big difference?

I'm still pretty new to running full MVC and Razor :D

My code look like this for now:

@inherits umbraco.MacroEngines.DynamicNodeContext @if(Model.AncestorOrSelf(2).Descendants("FocusBox").Count() > 0) { <div class="container row" id="focusBoxes"> @foreach(var Boxes in Model.AncestorOrSelf(2).Descendants("FocusBox")) { <div class="col-lg-3"> @if(Boxes.HasValue("focusImage")) { <img src="@Boxes.Media("focusImage", "umbracoFile")" width="100%" /> } <h3> <a href="#"> @if(Boxes.HasValue("header")) { @Boxes.header }else{ @Boxes.name } </a> </h3> @if(Boxes.HasValue("content")) { <p>@Boxes.content</p> } @{ var myLink = "#"; if(Boxes.HasValue("internalLink")) { myLink = Boxes.internalLink; } <a href="#">@myLink</a> } </div> } </div> }

And my content tree looks something like this

website.com
Frontpage
--Boxes
----Box 1
----Box 2 
........

And every box has following properties:
header
image
content 
internalLink
externalLink
mediaLink
targetBlank

And right now i've placed the racor macro at the frontpage view/template.

I can do this in XSLT but not i razor for the moment :o) 

I should add, Razor Macros using DynamicNode are legacy and should not be used for anything new.

Hi Jeavon
Finally it works :D

And it make totally sense with partial views vs razor macros.

I really dont know if this is the best solution but i works for me :D

Here is my finally code:

@inherits Umbraco.Web.Mvc.UmbracoTemplatePage
@{
    var focusBox = CurrentPage.AncestorOrSelf(2).Descendants("FocusBox");
}

@if (focusBox.Any()){ 
    <div class="container row" id="focusBoxes">

    @foreach (var boxes in focusBox) 
    { 
        <div class="col-lg-3">

            @if (boxes.HasValue("focusImage"))
            {
                var focusImage = Umbraco.Media(boxes.focusImage);
                <img src="@focusImage.Url" width="100%" />
                }

            <h3>
                <a href="#">
                    @(boxes.HasValue("header") ? boxes.header : boxes.name) 
                </a> 
            </h3>

        @if (boxes.HasValue("content"))
        {
            <p>@boxes.content</p>
        }

        @{
            var myLink = "#";
            var target = "_self";

            if (boxes.HasValue("internalLink"))
            {
                myLink = Umbraco.NiceUrl(boxes.internalLink);
            }          
            else if(boxes.HasValue("externalLink"))
            {
            myLink = boxes.externalLink;
            }
            else if(boxes.HasValue("mediaLink"))
            {
            myLink = Umbraco.Media(boxes.mediaLink).Url;
            }          
            if(boxes.HasValue("openNewWindow"))
            {
            target = "_blank";
            }          
            <a target="@target" href="@myLink">@myLink @boxes.openNewWindow </a>
        } 
   </div> 
    } 
    </div> 
}

Great, that looks perfect to me :-)

Glad to hear, merry christmas and happy newyear to you my friend :D 

Merry Christmas and Happy New Year to you too!

is working on a reply...