Sign in Register
Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Nicholas Westby 2054 posts 7100 karma points c-trib
    Mar 10, 2014 @ 22:21
    Nicholas Westby
    0

    DocTypes Duplicated in "def.config" Under "Structure"

    uSync

    uSync 2.0.0rc4 with Umbraco 7.0.4.

    I just happened to notice that the allowed children document types are kind of duplicated in the def.config file. They are only kind of duplicated because for every DocumentType element there is also an empty DocumentType element, such as in this example (note that this has not caused any issues as far as I've seen):

    <Structure>
      <DocumentType />
      <DocumentType />
      <DocumentType>FirstType</DocumentType>
      <DocumentType>SecondType</DocumentType>
    </Structure>
    Copy Link
  • Kevin Jump 2310 posts 14695 karma points MVP 7x c-trib
    Mar 10, 2014 @ 23:11
    Kevin Jump
    0

    Hi yes.

    there is a bug in the Umbraco Package APIs that uSync uses to generate the xml when saving a doctype. the bug means that umbraco writes out the tag and doesn't put in the value.

    Its actually a post export process that uSync does that then puts in the two DocumentType values with values in. In an attempt to make it future proof (i.e. when this bug is fixed) it checks for the existence of the values before putting them in but (in the current version) it doesn't delete the blank values.

    I don't think the blank values will cause a problem - because they are just ignored on import - but the change to remove them is already in the next version which is built for umbraco 7.1 when it is released.

    to be honest i keep forgetting about the core bug - I should go submit a Pull request.

    Copy Link
Please Sign in or register to post replies

Write your reply to:

Draft