Hi Barry,

I don't know if anyone has started a SagePay provider, but with the .Net integration kit it should be pretty straight forward. I can help you get things scaffolded next week and we can setup a Skype call if your interested. Send me a DM =)

Hi Barry,

I understand from Rusty's tweet this morning that you now have this working. Is it possible to get a copy. The client I am working with at the moment uses sagepay so I was about to write my own provider, in fact, I was due to start today when I spotted Rusty's tweet suggesting you already have one working!

Thanks

Chris

Hi Chris

Sure thing Chris - the repo is at https://github.com/BluefinDigital/Merchello.Plugins.SagePay

I am working on it as we speak, but as of last night the form integration method is working.  Good timing!  NB My client only needs form integration, but if you like we can collaborate, so it is more useful for your needs and those of the wider Merchelo comunity.  SagePay integration methods: http://www.sagepay.co.uk/support/integration-kits-protocols-document

Instructions:

1. Clone the repo and build the solution
2. Drop the App_Plugins/Merchello.SagePay folder into /App_Plugins on your Umbraco site
3. Copy or reference the Merchello.Plugin.Payments.SagePay.dll and SagePay.IntegrationKit.DotNet.dll to your /bin
4. Configure the provider in the Merchello backoffice (Gateways page) - you also need to add a payment method for SagePay in the Payments tab

Hi Barry,

That's great. I'll start looking this afternoon. My client needs direct integration so i'll have some work to do! I have no experience in merchello payment providers so I've got a bit of learning to do as well but I have done many SagePay direct integration in the past so that should help somewhat.

Thanks

Chris

Hi Barry,

I have the sagepay direct integration working. I still have to write the 3D Secure part of it but for basic transactions, it's working. I have had to refactor a fair amount of code to support multiple payment providers which I have pushed to a fork of the project. I haven't actually worked on a git project collaboratively yet so please bear with me! Should I create a push request now so you can see where i'm at or should I wait until I have completed the 3D secure stuff?

Thanks

Chris

Chris,

I'm interested in what you mean by multiple providers ... in Merchello terms I think this means multiple "Methods" for the SagePay provider. If I'm correct in my assumption, what I believe needs to happen is tweak with the existing SagePayGatewayProvider" code a bit.

Is this what you meant?

I'm off for uWestFest next week but really would like to make sure you two do not hit a wall with your efforts. Let me know if you need anything in particular - can even do a Skype call if you get stuck!

Rusty

Hi Rusty,

I mean multiple methods for the same provider! The version of the sagepay provider I have now supports sagepay form and sagepay direct. I've already tweaked the code so that there are two methods which inherit from a base method. I took the same approach as the braintree integration. I'm close to being finished with the code now, the direct method is putting through payments successfully, I just need to implement 3D secure on it but i'm waiting on sagepay to turn 3d secure on for the account I have access to. I'm just very new to working on git projects collaboratively so wanted to make sure it was ok to submit a push request with my updated code!

Have a great time at uWestFest.

Thanks

Chris

Hi Chris,

Great work on the direct integration method.  I will be able to review your pull request tomorrow and check there are no conflicts with the form integration - absolutely no problem to keep pushing your updates and hopefully we can review with Rusty after he's done with uWestfest (BTW I'm also a Git noob re collaboration :-).

Hi guys, I'm currently working on an eCommerce solution using Merchello and my client wants to use SagePay. We're going to be using the Server Integration method and I'd be interested adding Server Integration as a method in this provider.

I just pulled down the repository https://github.com/BluefinDigital/Merchello.Plugins.SagePay and it only seems to contain the Forms integration method. Is there any way I can see what you've been working on Chris to see how you've refactored things and to make sure what I do is compatible with your changes...

Hi David,

My fork should be listed under the forks for the repository. Alternatively the direct url is here: https://github.com/chris64digital/Merchello.Plugins.SagePay

It would definitely be better to add the extra method to my updated version as the original doesn't support multiple methods. Fingers crossed Barry will be able to accept my pull request though there are a lot of changes so it might take a little while to review!

Chris

Hi Guys,

I am reviewing this at the mo.  Apologies for the delay.  Looks good so far hopefully will have it merged in an hour.

Barry

OK Guys - I have merged the PR and pushed up to master.

https://github.com/BluefinDigital/Merchello.Plugins.SagePay

Great work Chris thanks for your input!  One thing I'd like to check with you is if the all settings saved with the Gateway provider are in the right place e.g. ReturnUrl, CancelUrl etc.  If not, a refactor could be in order so to separate settings that pertain to the payment METHOD as opposed to global stuff (like VendorName and Encryption password).   This is my first Sagepay integration and I havent touched anyhting other than the basic FORM process so I'd like to get your thoughts - if so lets move the conversation over to GitHub please.

Hi Barry,

I'm happy to continue code discussion on github but i'm not really sure where code discussions actually go! Feel free to get it started and i'll give you my input.

Chris

In issues e.g https://github.com/BluefinDigital/Merchello.Plugins.SagePay/issues/4

Hi Barry,

I'm now working on adding Paypal to the supported methods for sagepay direct. Unfortunately, unlike the normal sagepay direct, the paypal integration relies on sending the customer to paypal then getting a callback from sagepay once complete. I believe that it is very similar to the way that the sagepay form integration works. At the moment i'm struggling to work out how your form integration completes the callback. I can see where it gets the url from sagepay to send the customer to but I can't spot the code for responding to the callback. Would this part be implemented in front-end code?

Thanks

Chris

Hi Chris, 

Sorry for the delay I have been away on holiday.  The code that responds to the callback is in the SagePayApiController class:

https://github.com/BluefinDigital/Merchello.Plugins.SagePay/blob/master/src/Merchello.Plugin.Payments.SagePay/Controllers/SagePayApiController.cs

There are 2 methods in here, SuccessPayment and AbortPayment.  The URLs to these methods are called by SagePay after they process the payment via Form Integration.  Hope this helps.

Can't get the settings tab to work - details here https://github.com/BluefinDigital/Merchello.Plugins.SagePay/issues/8

I'm working on fixing this issue right now but am hoping that Rusty can shed some light on why it's not working!

At the moment, when the system does the GetResolvedPaymentGatewayProviders call it returns the sagepay provider with no extended data but I can't work out why. I'm away for a couple of days now so will hopefully have this working when I get back since I also need it working on a 1.9 site!

Rusty: Is there something we haven't implemented on this provider that should be populating the extended data? I can see it working for the smtp notification provider but I can't see what is different with this provider!

Thanks

Chris

I'll have to checkout the provider to be certain, but my first thought is there probably needs to be an event handler setup to create some default extended data values when the provider is "Activated". Is there an event handler setup?

@Chris Foot ... I hope you're talking about my issue!?! :-)

I am starting to get rather worried now, my project has to be working before the end of July ... and that is fast approaching!

I have a fix for issue 8 and have updated my pull request for the update. If you need this before the request is accepted then you can get the source from my fork of the repository. It should compile easily enough. I have not tested the checkout process yet, it may just work but i'll let you know later!

Chris

Umm, downloaded code from your repository and compiled OK. removed previous SagePay gateway code and copied over the new version (including DLLs).

The SagePay gateway configuration now appears to work (it displays correctly and saves), but I can't add a Payment Provider. It is there to be added (I need the Forms version), but when I save I get:

Received an error from the server

Failed to payment provider methods for: 31fda06c-a9d3-4dfb-9773-63724e0977b4

EXCEPTION DETAILS:

: STACKTRACE:

I'm just looking into that one! Should have something later this afternoon but i'll go through the whole payment process before I commit again.

Looks like the PaymentGatewayMethod attribute needed updating to include the two new payment editors. I'm going to continue testing and commit/push at the end of the day once i'm convinced it's all working correctly.

Ok, my latest commit appears to be working for me. I did have to clean the project before it started working but it all looks good now. I've also successfully submitted a test payment. I have further testing to do but feel free to give it a try and let me know how you get on.

Cheers

Chris

Darn ... got all the way to the end of checkout and when I select SagePay ... the Confirm button disappears :-(

Hi Gordon,

This is definitely working for me now. Which method are you using, form or direct?

Chris

Form

The Confirm button is there for Cash sale, but disappears when I select SagePay.

@Gordon

In your web.config try setting the Bazaar:ResolvePaymentForms to false if the controller you are using is not inheriting from PaymentMethodUiController{T} with a GatewayMethodUiAttribute

    <add key="Bazaar:ResolvePaymentForms" value="false" />

@Chris - are the instructions above still correct and complete? (As given to you by Barry)

Where is the code for that page, how can I debug what is going wrong?

Oh yes, setting the Bazaar:ResolvePaymentForms config value to True stops the SagePay option appearing in the dropdown on the payment form.

I am trying to figure out how to add a controller / form (?) - does anyone have any example code of how I would write a controller that inherits from PaymentMethodUiController{T} with a GatewayMethodUiAttribute?

@Chris - I am still stuck on getting my "Confirm" button to actually open up the SagePay payment form :-(

I know you are using "direct" mode, but maybe your controller code might give me some clues as to what I need to do? (How to call the plugin code to make the Sage form page appear).

I'm in the exact same position as Gordon. It's on a fresh 'combined' Merchello 1.9.0/Bazaar install on Umbraco 7.2.8.

I've pulled down Chris Foot's latest fork, built it (had a copule of issues with Nuget pulling in Merchello 1.8.0 instead of 1.9.0 so had to manually copy over 1.9.0 Merchello dlls to get it to build), copied 'Merchello.SagePay' into App_Plugins in my site, activated the SagePay payment provider in the Merchello Gateway Providers section and entered the configuration details, then added it in the 'Payment' tab too.

Now when I check out on the front-end I see both the cash and SagePay payment options in a drop-down but selecting 'SagePay' makes the 'Confirm sale' button disappear.

Can anyone offer any advice as to what to do now?

Thanks

Thanks Biagio, but I'm not entirely sure what you mean? I already updated the references to 'Merchello.Core', 'Merchello.Examine' and 'Merchello.Web' in SagePay plug-in solution, to reference the dlls from Merchello 1.9.0 (rather than 1.8.0 which it was looking for).

@Dan - to make the button appear, I needed to create a controller (in my project, called it "SagePayPaymentMethodController")

    [PluginController("MerchelloSagePay")]
[GatewayMethodUi("SagePayIFrame")]
public class SagePayPaymentMethodController : BazaarPaymentMethodFormControllerBase
{
    public override ActionResult RenderForm(CheckoutConfirmationForm model)
    {
        return this.PartialView(PathHelper.GetThemePartialViewPath(model.ThemeName, "SagePayFormPaymentMethodForm"), model);
    }

   protected override IPaymentResult PerformProcessPayment(SalePreparationBase preparation, IPaymentMethod paymentMethod)
    {
    }
}

I also created a partial view in my Merchello Bazaar theme folder:

@using System.Web.Mvc.Html
@using Umbraco.Web
@using VintageFineArms.site.Controllers
@inherits Umbraco.Web.Mvc.UmbracoViewPage<Merchello.Bazaar.Models.CheckoutConfirmationForm>

<!-- SagePay Form Payment Method -->
@using (Html.BeginUmbracoForm<SagePayPaymentMethodController>("ConfirmSale", null, new { @id = "ConfirmSale" }))
{
    @Html.AntiForgeryToken()
    @Html.HiddenFor(x => x.ShipMethodKey, new { @class = "selected-shipmethod-key" })
    @Html.HiddenFor(x => x.PaymentMethodKey, new { @class = "selected-paymentmethod-key" })
    @Html.HiddenFor(x => x.CustomerToken, new { @id = "customer-token" })
    @Html.HiddenFor(x => x.ReceiptPageId)
    <div class="control-group">
        <button type="submit" class="btn btn-primary">SagePay</button>
    </div>
}

That (I think!?) got me a button that appears when I select SagePay. The next problem is what to do when the button is clicked. You end up in "PerformProcessPayment" above...

Because I have not got the actual button actually working, I cannot confirm yet if the view, above, is correct.

Hi Guys,

I am still here! Unfortunately I have a project that I have to finish asap but when that is over i'll take a look at what is happening with this. Are there any errors in the log or console when you select sagepay from the dropdown?

Hi Chris, my problem (at least) is that I didn't know what code was required to show the button in the first place. That is now sorted (I hope) and the problem has moved onto the code required to actually make the SagePay payment pages appear (I am using the Form method).

I cannot find any example code and code produced while talking with Rusty also does not work.

my situation sounds the same as yours - this website needs to be live before the end of July! :-)

Hi,

I think that you need to follow the same path as Paypal provider. Into Bazaar controller

[PluginController("Bazaar")]
    public class SalePreparationOperationsController : SurfaceControllerBase

you need create an action ( customize it for your needs ):

[HttpPost] public ActionResult ConfirmPayPalSale(CheckoutConfirmationForm model) { if (!ModelState.IsValid) return this.CurrentUmbracoPage();

        var preparation = Basket.SalePreparation();
        preparation.RaiseCustomerEvents = false;

        preparation.ClearShipmentRateQuotes();
        var shippingAddress = Basket.SalePreparation().GetShipToAddress();

        // Get the shipment again
        var shipment = Basket.PackageBasket(shippingAddress).FirstOrDefault();

        // get the quote using the "approved shipping method"
        var quote = shipment.ShipmentRateQuoteByShipMethod(model.ShipMethodKey);

        // save the quote
        Basket.SalePreparation().SaveShipmentRateQuote(quote);

        var paymentMethod = GatewayContext.Payment.GetPaymentGatewayMethodByKey(model.PaymentMethodKey).PaymentMethod;
        preparation.SavePaymentMethod(paymentMethod);

        // AuthorizePayment will save the invoice with an Invoice Number.
        var attempt = preparation.AuthorizePayment(paymentMethod.Key);

        if (!attempt.Payment.Success)
        {
            return this.CurrentUmbracoPage();
        }

        // Trigger the order confirmation notification
        var billingAddress = attempt.Invoice.GetBillingAddress();
        string contactEmail;
        if (string.IsNullOrEmpty(billingAddress.Email) && !CurrentCustomer.IsAnonymous)
        {
            contactEmail = ((ICustomer)CurrentCustomer).Email;
        }
        else
        {
            contactEmail = billingAddress.Email;
        }

        if (!string.IsNullOrEmpty(contactEmail))
        {
            Notification.Trigger("OrderConfirmation", attempt, new[] { contactEmail });
        }

        // store the invoice key in the CustomerContext for use on the receipt page.
        CustomerContext.SetValue("invoiceKey", attempt.Invoice.Key.ToString());

        string url = attempt.Payment.Result.ExtendedData.GetValue("RedirectUrl");
        return Redirect(url);
    }

and then into ~/App_Plugins/Merchello.Bazaar/Themes/Flatly/Views/Partials/CheckoutConfirmationForm.cshtml

put in

 <!-- PayPal Payment Method -->
        <div id="PayPalPayment" class="payment-method-form">
            @using (Html.BeginUmbracoForm<SalePreparationOperationsController>("ConfirmPayPalSale", null, new { @id = "ConfirmPayPalSale" }))
            {
                @Html.HiddenFor(x => x.ShipMethodKey, new { @class = "selected-shipmethod-key" })
                @Html.HiddenFor(x => x.PaymentMethodKey, new { @class = "selected-paymentmethod-key" })
                @Html.HiddenFor(x => x.CustomerToken, new { @id = "customer-token" })
                @Html.HiddenFor(x => x.ReceiptPageId)
                <div class="form-group">
                    <button type="submit" class="btn btn-primary">Confirm Sale</button>
                </div>
            }
        </div>

I'm tring to follow this to made work Braintree.

@Rusty : we need a better documentation to code payment plugin.

OK, this is now solved / working! :-)

With MASSIVE thanks to Rusty, we got there in the end.

Great! How did you resolve it?

Could you post your code, please?

is working on a reply...