deleted media still showing

Go to solution

Press Ctrl / CMD + C to copy this to your clipboard.

Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at

Anamarija Horvat 25 posts 140 karma points

Feb 17, 2017 @ 18:09
0

Deleted Media still showing

Extending Umbraco and using the API

Umbraco 7
I am looping through media folder with certain Id to display images. I deleted some of images from there and I don't see them in back office, but I still get them while looping, it acts like they are still there. Here is the code:
```
var media = Umbraco.Media(1472);
@foreach (var file in media.Children)
{
      var ImageId = Umbraco.Media(file.Id);
      var Image = ImageId.UmbracoFile;
      <img src="@Image" class="lightbox-image "/>
}
```
In variable "Image" there are still deleted files Url's. Since they're deleted It renders on my page as "Url not found". Why is it doing it? How can I really delete something from folder, or how to display only items that aren't deleted.
Copy Link
Stefano 61 posts 313 karma points c-trib

Feb 17, 2017 @ 18:50

0

Is it that they are in the bin, so unpublished and not in the main media folder?

Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 17, 2017 @ 19:00

0

This shouldnt have any relation to this. You can add file and delete them in Umbraco media section. Adding works fine, but deleting doesnt. File is deleted and not there but looping still returns url for example /media/1024/image5.jpg even tough theres nothing there

Copy Link

Paul Wright (suedeapple) 277 posts 704 karma points

Feb 18, 2017 @ 10:35

Try something like this

 var media = Umbraco.TypedMedia(1472).Children.Where(x => x.IsVisible());

@foreach (var img in media)
{
    <img src="@img.Url" class="lightbox-image" />
}

Copy Link

Anamarija Horvat 25 posts 140 karma points

Feb 20, 2017 @ 08:17

0

This returns the error: cannot use a lambda expression as an argument to a dynamically dispatched operation without first casting it to a delegate or expression tree type

I tried this:

@foreach (var file in media.Children.Where("Visible"))

But didn't solve my issue

Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 20, 2017 @ 08:29
0
But this:
```
@foreach (var file in media.Children.Where("Visible"))
    {
        if(file.IsVisible)
```
Returns false for all files. Nothing is published, because it's in media section and there's not publish button there
Copy Link
Paul Wright (suedeapple) 277 posts 704 karma points

Feb 20, 2017 @ 11:35
0
Something like this should do it
```
    var media = Umbraco.TypedMedia(1089).Children.OfTypes("Image").Where(x => x != null);


@foreach (var img in media)
{

    <img src="@img.Url" class="lightbox-image" />
}
```
Also in your Developer Section, check the XML Cache integrity for the Media Items.
Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 20, 2017 @ 14:37

0

It does not. It's not null, Umbraco doesn't delete meta data. So I can even get height, type, all the information about deleted file. Bascially everything is kept except file itself.

Copy Link
Stefano 61 posts 313 karma points c-trib

Feb 20, 2017 @ 15:00

0

Not too sure but I reckon you can check if the file inside the media element is != null (I think is called umbracoFile) or the url is null

Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 20, 2017 @ 15:13

0

That's my question actually, I dunno how to check is it null, because url itself isn't. I get /media/1024/image5.jpg for example.

Copy Link
Stefano 61 posts 313 karma points c-trib

Feb 20, 2017 @ 15:17

0

is .GetPropertyValue("umbracoFile") == null?

Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 20, 2017 @ 15:47

0

That's not null, that returns that url. I switched to another approach that I don't like very much, but it works. Instead of looping through folder, I made API where user needs to select all images himself through Multi Media Picker. That works but it's not what I wanted. I dunno why Umbraco acts the way he does and keeps all meta data.

Copy Link
Paul Wright (suedeapple) 277 posts 704 karma points

Feb 20, 2017 @ 15:51

0

What version of umbraco are you running?

Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 22, 2017 @ 15:39

0

7.4.3

Copy Link
Lee Kelleher 4020 posts 15802 karma points MVP 13x admin c-trib

Feb 22, 2017 @ 15:47

0

Hi Anamarija,

I got hit by this too... it's a bug, fixed in Umbraco v7.5.5

http://issues.umbraco.org/issue/U4-9137

If you can't upgrade, then the best you can do is to check the media node's Path, see if it starts with "-1,-21,".

Cheers,
- Lee

Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 22, 2017 @ 15:51

0

Thank you!

Copy Link
Damiaan 442 posts 1301 karma points MVP 6x c-trib

Feb 21, 2017 @ 10:49

0

Sounds like your examine indexes are not up to date.

If you search for the media items in the develop tab, can you still find this image? which you are referring? If so, rebuild the index.

Copy Link
Anamarija Horvat 25 posts 140 karma points

Feb 22, 2017 @ 15:42

0

I am sorry I don't understand. I don't see media in developer's tab, and unfortuanatly don't know what examine indexes are. Can you elaborate so I can rebuild them. But if you ask do I see media in Media section I don't.

Copy Link
James Strugnell 84 posts 192 karma points

Jan 30, 2018 @ 11:19

0

I just had this same issue running 7.6.1. Tried everything, then found this article and an Examine re-index fixed it.

Copy Link

David Armitage 505 posts 2073 karma points

Jun 21, 2020 @ 04:07

Hi Guys

Anyone having trouble with Umbraco 8. Here is how I do it.

public void DeleteMedia(int mediaId)
        {
            try
            {
                IMedia media = _mediaService.GetById(mediaId);
                if(media != null)
                    _mediaService.Delete(media);

            }
            catch (Exception e)
            {
                _logger.Error<UmbMediaService>("DeleteMedia | Exception: {0} | Message: {1}", e.InnerException != null ? e.InnerException.ToString() : "", e.Message != null ? e.Message.ToString() : "");
            }
        }

Copy Link

is working on a reply...

Please Sign in or register to post replies

Flag this post as spam?